Open dcsan opened 3 years ago
lets' discuss this one here, big topic
I think it's prob best to playthrough and test all the lights to see where it isn't syncing up.Β
First light should come on when clothes are donned, then proceed from there. There should only be 3 lights on in the dark, but now there is still the old 4 lights image.
Sometimes the image doesn't sync with the icons or the textual description as seen in this one, at the beginning when no lights are on:
Another time is here:
you mean
tasks 3/6 img: 2 lights emoji: 2 lights?
it should be 3 lights?
The "task x/x" is something you coded so I don't want to comment on that. I think your task number is +1 of the lights, but you can check that part to see if it's synced. There's also a difference between "doing task 3" vs. "task 3 completed" since the completion of a puzzle task results in a light coming on.
What I mean is that at any point there are 3 different ways that the number of lights currently on is indicated to the player.
The proper illustration should always match the state of the lights in the room. The progression is: no lights, 1 light, 2 lights, 3 lights/dark room, 4 lights.
You can see in the image here how this is not synced properly as only one light should be on.
Easiest way is to run through the game and test each of these by "look room" and "look lights" during each state to check.
this lights thing is very confusing to track. I just need a clear list of what lights go with what and I can fix the story.
enter room - no lights you get assigned task1 - to get dresssed on completion 1 light comes on?
so basically at start of task1 = 0 light at end of task1 => task2 => 1 light
so basically task[num] - 1
task1: get dressed => 0 light => complete => 1 light task2: 1 light exercise => task3: 2 lightss wash => task4: 3 lights / (dark room) green =>
seems to match:
[Task 4/6] Three of the green lights are on, and a yellow light seeps through the window.
if that's correct one of us could clean up the script
- name: task1
imageUrl: bureau/ch1/500/bh-ch1-no-lights.jpg
short: "`[Task 1/6]` You are in what appears to be a mental patientβs bedroom. \n
You see a desk, a sink, a window, a door, lights, and a wall covered with images. \n"
navbar: full
# repeat room description
- name: task2
imageUrl: bureau/ch1/500/bh-ch1-1-light.jpg
short: "π‘ β¦ β¦ β¦\n
`[Task 2/6]` You are in what appears to be a mental patientβs bedroom. \n
You see a desk, a sink, a window, a door, lights, and a wall covered with images.
\n
\nOne of the green lights has come on.
"
navbar: full
- name: task3
imageUrl: bureau/ch1/500/bh-ch1-2-lights.jpg
short: "π‘π‘ β¦ β¦\n
`[Task 3/6]`
Two of the green lights are on."
navbar: full
- name: task4
# imageUrl: asylum/rooms/cell-dark.jpg
# imageUrl: bureau/ch1/500/bh-ch1-3-lights.jpg
imageUrl: bureau/ch1/500/bh-ch1-4-lights-dark.jpg
short: "π‘π‘π‘ β¦\n
`[Task 4/6]`
Three of the green lights are on, and a yellow light seeps through the window."
navbar: full
- name: task5
imageUrl: bureau/ch1/500/bh-ch1-4-lights.jpg
short: "π‘π‘π‘π‘\n
All four of the green lights are on."
- name: lights
called: wall lights|lightbulbs|lamps
states:
- name: default
short: A vertical row of small green lightbulbs is built into the wall above the sink.
- name: task1
short: β¦ β¦ β¦ β¦
None of the lights are lit up.
- name: task2
short: π‘ β¦ β¦ β¦
One of the green lights has come on.
- name: task3
short: π‘π‘ β¦ β¦
Two of the green lights are lit up.
- name: task4
short: π‘π‘π‘ β¦
Three of the green lights are lit.
- name: task5
short: π‘π‘π‘π‘
More green lights are lighting up; it seems you're making progress.
There's also a difference between "doing task 3" vs. "task 3 completed" since the completion of a puzzle task results in a light coming on.
has code
imageUrl: bureau/ch1/500/bh-ch1-4-lights-dark.jpg
short: "π‘π‘π‘ β¦\n
is this still wrong?
easy enough to change it back to:
# imageUrl: bureau/ch1/500/bh-ch1-3-lights.jpg
synced at least
OK there is no '3 lights dark' so ..
there's only 3 lights - normal so ... i'm not sure if we're missing an image or how to deal with this
I did send a three lights dark already in response this issue this past week. Iβll resend when I have the chance.
On Sun, Nov 15, 2020 at 4:10 AM dc notifications@github.com wrote:
there's only 3 lights - normal so ... i'm not sure if we're missing an image or how to deal with this
[image: image] https://user-images.githubusercontent.com/514002/99156010-53439f80-2672-11eb-98f7-34446e390b2c.png
β You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/dcsan/storydata/issues/15#issuecomment-727259178, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXLMT4K5QTQ4QOHIL77Z63SP3P4BANCNFSM4TQT3DCA .
ok found the image.
think done now
seems like it goes backwards
another issue
lights
right now
But it may get out of sync. it's a bit complicated/messy to track really (one thing i want to clean up with a proper hints/task system). did you notice where it goes out of sync?
or should it be
maybe thats why i'm confused ach task3 is out of sync. let me know what it should be here and i'll see if we can make a system to fix it. ideally this would be part of a task list and we'd assign everything in a centralised place, but thats a lot more code. its just a mess cleaning up scatted across the script. also i did get confused originally on the counting.
I could make something like
progress: 3
a function that just renders the little progress bar. but then it would be more "fixed"task2
task3
yeah looks like this is out of sync
task4
it looks like maybe lights were edited?