search

dcsan / storydata

0 stars 0 forks source link

fix MJ image in web popup #20

Closed dcsan closed 3 years ago

dcsan commented 3 years ago

also change the scaling to fit inside window

dcsan commented 3 years ago

![Uploading image.png…]()

dcsan commented 3 years ago

image

dcsan commented 3 years ago

still need to fix CSS on back to match front complex due to supporting any aspect ratio

image

intellikat commented 3 years ago

Do you need the matching background for this as a separate image rather than a fake grey brick wall?

On Sun, Nov 15, 2020 at 1:29 PM dc notifications@github.com wrote:

Reopened #20 https://github.com/dcsan/storydata/issues/20.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dcsan/storydata/issues/20#event-3997107310, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXLMT6RPT6GDFFVAVXBCRDSP5RNHANCNFSM4TQUTADA .

dcsan commented 3 years ago

yeah a bg would be good. a tile pattern would be best - this expands to fill the screen as it can be any shape/size.

tall / wide etc.

intellikat commented 3 years ago

It should be consistent with the actual wall image though.

On Sun, Nov 15, 2020 at 9:34 PM dc notifications@github.com wrote:

yeah a bg would be good. a tile pattern would be best - this expands to fill the screen as it can be any shape/size.

tall / wide etc.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dcsan/storydata/issues/20#issuecomment-727570646, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXLMTZNJQKCR76VAKGSR5DSP7KF5ANCNFSM4TQUTADA .

intellikat commented 3 years ago

The wall in the room isn't a brick wall.

On Sun, Nov 15, 2020 at 10:06 PM John Knauss john.knauss@gmail.com wrote:

It should be consistent with the actual wall image though.

On Sun, Nov 15, 2020 at 9:34 PM dc notifications@github.com wrote:

yeah a bg would be good. a tile pattern would be best - this expands to fill the screen as it can be any shape/size.

tall / wide etc.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dcsan/storydata/issues/20#issuecomment-727570646, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXLMTZNJQKCR76VAKGSR5DSP7KF5ANCNFSM4TQUTADA .

dcsan commented 3 years ago

yeah just the color then?

intellikat commented 3 years ago

No I'll make it match with the texture of the illustration. Is this a square?

dcsan commented 3 years ago

actually i did it with code

but i can use an image. anything that tiles should be ok

.brick {
  width: 100vw;
  height: 100vh;
  background-color: #DFDBE5;
  background-image: url("data:image/svg+xml,%3Csvg width='42' height='44' viewBox='0 0 42 44' xmlns='http://www.w3.org/2000/svg'%3E%3Cg id='Page-1' fill='none' fill-rule='evenodd'%3E%3Cg id='brick-wall' fill='%239C92AC' fill-opacity='0.4'%3E%3Cpath d='M0 0h42v44H0V0zm1 1h40v20H1V1zM0 23h20v20H0V23zm22 0h20v20H22V23z'/%3E%3C/g%3E%3C/g%3E%3C/svg%3E");
  z-index: 1;
}
intellikat commented 3 years ago

Oh, needs to tile? Can't be a single image?

dcsan commented 3 years ago

no... that would be huge. i mean, i guess it could be... but if its just a small thing its a waste to have a full screen if its a small JPG i could scale it to fill

intellikat commented 3 years ago

This is the actual.

mj-background-01

intellikat commented 3 years ago

Simplified. mj-background-02

intellikat commented 3 years ago

Or tile the general color. mj-wall-tile

dcsan commented 3 years ago

think it should be a color or pattern or you'll notice it floating around maybe

dcsan commented 3 years ago

rgb 184, 174, 130

dcsan commented 3 years ago

B8AE80

dcsan commented 3 years ago

image

i can mix texture and the color

dcsan commented 3 years ago

i guess i could do a gradient color from code... agh i'll spend time on other stuff

image

dcsan commented 3 years ago

I like the transparent masking tape on the davinci. paper textures are nice.

Screen Shot 2020-11-11 at 08 02 55

intellikat commented 3 years ago

Flat yellow-tan is fine for now. Can fix it later. Don’t put a background that doesn’t match the actual game image... it looks tacky and is confusing.

On Mon, Nov 16, 2020 at 12:29 AM dc notifications@github.com wrote:

Closed #20 https://github.com/dcsan/storydata/issues/20.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dcsan/storydata/issues/20#event-3997570484, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXLMT4XLFAFVBMC644ZY4DSP76YPANCNFSM4TQUTADA .