search

dcsaorg / DCSA-BKG

0 stars 1 forks source link

moved shipmentEvent helper methods to ShipmentEventMapper #114

Closed pimg closed 2 years ago

pimg commented 2 years ago

depends on: https://github.com/dcsaorg/DCSA-Event-Core/pull/326 moved helper methods of shipment_events into mappers in event_core and moved the check methods to Booking entity.

nt-gt commented 2 years ago

I only had a minor nit to some "unrelated code" (that I immediately resolved to avoid it causing a "blocking" issue). It is at https://github.com/dcsaorg/DCSA-BKG/pull/114#discussion_r867888667 in case you want to sneak it in.