Closed RyanMarten closed 4 years ago
Automatic deployment when we push to master too?
adding comment to firebase deploy with the SHA of the git commit https://github.community/t5/GitHub-Actions/Accessing-commit-message-in-pull-request-event/td-p/40856
Using this github action to help out: https://github.com/marketplace/actions/github-action-for-firebase
Actually the answer was to install firebase-tools globally using npm install -g firebase-tools
Used my own action instead of the one that is out there --> the other one added 30 seconds of wait time.... not great
- name: Install Firebase Tools
run: npm install -g firebase-tools
working-directory: app
- name: Deploy to firebase
working-directory: app
run: firebase deploy --token $FIREBASE_TOKEN -m $SHA
env:
FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
SHA: ${{ github.sha}}
Edit react_app.yml to add this functionality. Should only deploy if it passes tests.