search

dcsil / dream-team

Team repository for Dream Team
https://dreamtune-cdf8a.web.app/auth/login
0 stars 1 forks source link

Tests for scraper #212

Open ribhav99 opened 4 years ago

ribhav99 commented 4 years ago

Add tests for the js scraper

RyanMarten commented 4 years ago

https://firebase.google.com/docs/functions/unit-testing

RyanMarten commented 4 years ago

need to generate coverage report

RyanMarten commented 4 years ago

uses mocha

RyanMarten commented 4 years ago

make sure to generate a coverage report (may not be the right link https://istanbul.js.org/docs/tutorials/mocha/) but you need to configure the reporter

RyanMarten commented 4 years ago

https://dcsil-team-app.herokuapp.com/docs/software/code/coverage

RyanMarten commented 4 years ago

https://github.com/dcsil/dream-team/blob/master/app/package.json#L66-L70

This is how I configure jest (you will be using mocha not jest)

RyanMarten commented 4 years ago

https://github.com/dcsil/dream-team/blob/master/app/package.json#L30-L35

This is where the npm commands are created. I added the "test-once" command. Do something similar

jollyredflames commented 4 years ago

This is not happenning rn!

jollyredflames commented 4 years ago

Lets fix coverage before doing pull requests in the future

jollyredflames commented 4 years ago

Also, don't merge PR till atleast one person looks at it to simulate a proper flow

ribhav99 commented 4 years ago

Yeah spoke to ryan when it happened dw