Closed jiricekcz closed 2 years ago
Good catch, thank you!
But I would suggest to change the implementation according to the index.d.ts file, to follow the convention to have the options
parameter always as last argument. If you want please change the following and I'll happily merge your PR:
rankings.js
such that the optionsGiven
parameter is the last: https://github.com/dcts/opensea-scraper/blob/6fe68bc3276d935dc5e6f9ecad53d537f4b3c1e8/src/functions/rankings.js#L20OpenseaScraper.rankings()
function in README.md (https://github.com/dcts/opensea-scraper/blob/main/README.md#usage) closed by PR #56
Parameters of ranking functions were swapped in the declaration when compared to the implementation. This causes invalid data when using with typescript, because the chain is passed in as options and no warnings are raised.