Update dependencies and Configure Prettier with pre-commit hook

dcts / opensea-scraper

Scrapes nft floor prices and additional information from opensea. Used for https://nftfloorprice.info

MIT License

184 stars 73 forks source link

Update dependencies and Configure Prettier with pre-commit hook #67

Closed emirsavran closed 1 year ago

emirsavran commented 1 year ago

I updated dependencies to their latest versions to make it easy to keep up with the ecosystem. I also added Prettier, which is a pretty standard in the JS ecosystem, to enforce a code style.

One breaking change is that Puppeteer dropped the support for Node V12, so the project needs at least Node v14 right now.

dcts commented 1 year ago

@emirsavran thanks for the effort! :) Currently looking into it.

Question: Why did you add the .vscode folder? I feel like this belongs in .gitignore as its editor specific and has nothing to do really with the package. Was it a mistake?

dcts commented 1 year ago

Theres too much going on in this PR honestly. So my main feedback would be:

updating packages is great, can you do a seperate PR for that? Having at least node 14 is fine. Did you test if the package still works with the updated packages?
I dont really like the linter, but maybe need to look more into it. Some of the formatting is nuts :P

dcts commented 1 year ago

closing due to inactivity. Feel free to reopen if needed. :)