Closed emirsavran closed 1 year ago
@emirsavran thanks for the effort! :) Currently looking into it.
Question: Why did you add the .vscode
folder? I feel like this belongs in .gitignore
as its editor specific and has nothing to do really with the package. Was it a mistake?
Theres too much going on in this PR honestly. So my main feedback would be:
closing due to inactivity. Feel free to reopen if needed. :)
I updated dependencies to their latest versions to make it easy to keep up with the ecosystem. I also added Prettier, which is a pretty standard in the JS ecosystem, to enforce a code style.
One breaking change is that Puppeteer dropped the support for Node V12, so the project needs at least Node v14 right now.