search

dcu / mongodb_exporter

MongoDB exporter for prometheus.io
MIT License
353 stars 216 forks source link

vendor prometheus client to v0.8.0 (fixes #40) #45

Closed bamarni closed 7 years ago

bamarni commented 7 years ago

I've run the following command if you prefer to do it yourself : 

git clone --depth=1 -b v0.8.0 https://github.com/prometheus/client_golang.git vendor/github.com/prometheus/client_golang && rm -rf vendor/github.com/prometheus/client_golang/.git

Unfortunately at the moment it cannot use gopkg (due to https://github.com/niemeyer/gopkg/pull/42).

deepthawtz commented 7 years ago

thanks for taking this on. I think we should just pick a package manager and use that, it'll ensure the most consistent results. I've been using glide for other projects

deepthawtz commented 7 years ago

@bamarni I took a different approach here https://github.com/dcu/mongodb_exporter/pull/46

Would you mind trying that out? The downside is contributors will need to install glide but the upside is consistent results for all contributors. Closing this PR, appreciate the thought & effort

bamarni commented 7 years ago

@deepthawtz : sure, I can imagine that shipping the whole dep is not very appealing :)

I've left a comment in your PR, otherwise seems good to me :+1:

(An alternative is also to use gopkg.in for imports once https://github.com/niemeyer/gopkg/pull/42 is fixed.)