search

dcu / mongodb_exporter

MongoDB exporter for prometheus.io
MIT License
356 stars 216 forks source link

use COPY instead of RUN git clone origin master in Dockerfile #72

Closed smaftoul closed 7 years ago

smaftoul commented 7 years ago

The current Dockerfile clones from github origin master the code when building it. It doesn't allow you to build a release / container of your current development. By COPYing instead of RUN git clone we can have a better workflow for developping and building containers.

dcu commented 7 years ago

@bewt85 can you check this one on your env?

bewt85 commented 7 years ago

@dcu I've just tested this PR on OSX and it worked fine. I then made a local change, rebuilt and the local change makes it's way into the built container.

I'd say it's good to merge.

smaftoul commented 7 years ago

This is indeed how I work locally to rebuild the container before comitting / pushing , to my remote. Without changing this line, I cannot easily rebuild the exporter based on my modifications.