search

dcurletti / redux-infinite-scroll

React infinite scroll component designed for a Redux data-flow.
MIT License
178 stars 47 forks source link

Usage with Immutable js #30

Closed shotaK closed 7 years ago

shotaK commented 7 years ago

Is library supposed to work with Immutable js types?

As I see in ReduxInfiniteScroll.jsx file, proptype checking for Immutable types is commented. While _totalItemsSize functions still checks for size of immutable types, which in my case caused some problems, when using library with native Javascript arrays.

dcurletti commented 7 years ago

Hi @shotaK , yes the library works with Immutable js. I only commented out the proptype checks.

dcurletti commented 7 years ago

I'm going to close for now, but feel free to ask more questions.