Ensure that the event scroll listener gets detached when not needed.

dcurletti / redux-infinite-scroll

React infinite scroll component designed for a Redux data-flow.

MIT License

178 stars 47 forks source link

Ensure that the event scroll listener gets detached when not needed. #39

Open mike7515 opened 7 years ago

mike7515 commented 7 years ago

In current implementation the event scroll listener gets attached when needed, but it never gets detached. (see componentDidMount and componentDidUpdate).

Thank you !

geekus commented 7 years ago

Oh, nice. I ran into this issue, and considered sending a similar PR. Any chance of merging, @dcurletti?