Closed pythonesque closed 10 years ago
I think my only gripe with this is the name of the flag -- passing an extra parameter to the linker has nothing to do with reentrancy (in this case). I'd probably call it something more obvious like linker_takes_context
.
I should qualify that last comment -- it could be related to reentrancy if you're mutating global state in your linker function and using the module in a multi-threaded environment, but I doubt that's the norm.
Fair enough, resubmitted (though if you want to go with the reflection variant that's cool too).
Thanks. Fix the test case (looks like just a missed rename), and I'll go ahead and merge it.
Done :)
...afe use of a user defined linker with context.
This is what I was discussing in issue #11. It's basically just pulled straight from the changes I made in my own project, plus a test.