tests? - Githubissues

dcwatson / deflate

Python extension wrapper for libdeflate.

MIT License

25 stars 6 forks source link

tests? #13

Closed ThomasWaldmann closed 2 years ago

ThomasWaldmann commented 2 years ago

would be cool to have some tests for the code, like:

[X] roundtrip (test decompress(compress(data)) == data for misc. data values)
[X] test api, exception raising
[X] pytest is a nice testing framework

todo?:

[ ] "speed test" that always succeeds and outputs speed as a side effect (maybe also in comparison to gzip / zlib python stdlib code)
[ ] pytest-benchmark is nice for benchmarks.

Can't be done / out of scope:

[ ] zlib compatibility? (test deflate_compress(data) == gzip_compress(data) for misc. data values)
[ ] test the different internal implementations, if possible

ThomasWaldmann commented 2 years ago

Hmm, I don't see how I could test the different internal implementations. Would need to force a specific one via the python api, but guess that is not possible (yet?).

zlib / gzip compat: seems like the deflate_compressed data is different for the same input data. but guess if this is not intended / expected, that is rather an issue for the libdeflate project, not for the python wrapper.

speed test: would you like to have that?