search

dcwatson / deflate

Python extension wrapper for libdeflate.
MIT License
25 stars 6 forks source link

fix pypy support? #35

Closed ThomasWaldmann closed 2 months ago

ThomasWaldmann commented 2 years ago

after adding testing to the automated wheel building running via github actions, i noticed that the pypy wheel does not test ok. likely no new issue, just nobody noticed yet / complained yet.

when this issue is fixed, the pypy wheel building can be re-enabled.

see there:

ThomasWaldmann commented 2 years ago

just noted that the deflate 0.3.0 pypi release did not have a pypy wheel.

ThomasWaldmann commented 2 years ago

Depending on what the goal will be with supporting PyPy or not, we could adjust the pypi metadata in setup.py accordingly:

        'Programming Language :: Python :: Implementation :: CPython',
        'Programming Language :: Python :: Implementation :: PyPy'
dcwatson commented 1 year ago

Seems like it's blocked on this:

https://foss.heptapod.net/pypy/pypy/-/issues/3837

I don't know if this is something we could work around or not, but not having used PyPy myself, I'm not inclined to spend much effort on it.

dcwatson commented 2 months ago

Seems like this would probably require using ctypes or CFFI - I'd imagine that would be a separate wrapper library. Closing this out.

henryiii commented 2 months ago

Fixed in #50.