search

dcwatson / deflate

Python extension wrapper for libdeflate.
MIT License
25 stars 6 forks source link

add adler32 functionality and tests #37

Closed maarten-k closed 1 year ago

maarten-k commented 1 year ago

exposes the adler32 function of libdeflate. Implementation is almost a copy of the crc32 implementation, only the initial value is 1 in adler32 (where crc32 has 0).

ThomasWaldmann commented 1 year ago

While you're at it, you could also correct the typo "alder32" in the commit comment.

ThomasWaldmann commented 1 year ago

Everything else looks pretty good and as expected, thanks for the PR!

maarten-k commented 1 year ago

Thanks for the review and thanks for spotting the mistake with the assert.