search

dcwatson / deflate

Python extension wrapper for libdeflate.
MIT License
25 stars 6 forks source link

feat: Stable ABI #48

Closed henryiii closed 2 months ago

henryiii commented 2 months ago

Wheel build here: https://github.com/henryiii/deflate/actions/workflows/build.yml

From logs:

Found previously built wheel deflate-0.7.0-cp311-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl, that's compatible with cp312-manylinux_x86_64. Skipping build step...

I've enabled running the tests on the built wheels in cibuildwheel, including running the 3.12 tests on the 3.11 Stable ABI wheels. I also added CPython 3.13 to the test matrix (beta 1 was just shipped for GHA yesterday, but it's pulling a6 still for some reason, maybe caching).

dcwatson commented 2 months ago

Love that it runs tests with the built wheels - hadn't seen that before. I don't think changing to bytearray is a big deal - I almost stuck with it for 0.7.0 - but I am bummed that there isn't a good way to do this with bytes without a second copy or private API. I suppose changes like this are what pre-1.0 releases are for.

henryiii commented 2 months ago

You could ask for it to be added to the limited API (for 3.14).