search

dcwatson / deflate

Python extension wrapper for libdeflate.
MIT License
25 stars 6 forks source link

docs: update install warning and changelog #51

Closed henryiii closed 1 month ago

henryiii commented 2 months ago

Some small suggested updates.

FYI, you can pass CMake defined using -Ccmake.define.SOME_VAR=... in pip and build if you'd like a non-envvar way to pass this.

dcwatson commented 2 months ago

Yup, I actually tried it that way first, but we were already using an envvar, so I kept it.

henryiii commented 2 months ago

Sounds good, as long as you know about it. :)