dd-harp / ramptools

Shared tools for the RAMP team
Other
0 stars 0 forks source link

updated location_table and added district shapefile #6

Closed d-hergott closed 1 month ago

d-hergott commented 2 months ago

Updated location table added from an API call on 08MAY2024. Added in a district shapefile for Uganda with geometries that are valid and align with the IDs in the loc_table to be used for plotting.

aucarter commented 2 months ago

A couple questions... what are the emonc and emonc_unsupported_and_cross_cutting columns in the loc_table? When I load the library and try to plot the shapefile i get the following error: > plot(uga_district_shp) Error in data.matrix(x) : 'list' object cannot be coerced to type 'double'

Is that unusual? I feel like I remember being able to plot shapefile.

d-hergott commented 2 months ago

hmm...I did not add those emonc columns myself- they were in the file that you downloaded (I just copy and pasted it into the file and changed the name- I did not manipulation for this).

For the shapefile- you should be able to plot it. When I load it in outside of this package, I have no issues. Can you verify what the structure of the file is?

aucarter commented 2 months ago

Ok, i don't really see where those columns were made in constructing the initial location table. Is this the script that generated the location table used here?

image

aucarter commented 2 months ago

I think we should just get rid of the emonc columns but I am curious where they came from

d-hergott commented 2 months ago

Yes- that seems to be the code. I pulled in your file C:\Users\dhergott\Box\RAMP\Scratch\Austin\240508_location_hierarchy.csv which was made for that.

I'm fine deleting them!

Odd on the shapepfile. When I just load it in outside of the package, the geometries are not as a list. Are they pulled in just using load, or is there another way the .rda files are loaded in the package?

aucarter commented 2 months ago

I'm missing where in the code emonc columns are created, so I am confused. seems like we will need to investigate shapefile loading via a package

d-hergott commented 1 month ago

Made a new issue for adding in the dependency and am merging this per discussion with Austin.