search

dd4t / dd4t-2-java

10 stars 21 forks source link

Added @JsonIgnoreProperties to all non-abstract classes #122

Closed alebastrov closed 2 years ago

alebastrov commented 4 years ago

…in order to prevent deserialization error. Also fixed sync possible issue as setting sync on holder may not be visible by other threads

RaimondKempees commented 2 years ago

This PR is too big. I don't want to add JsonIgnoreProperties everywhere, as all properties are known and explicit, so we catch new properties early (aka a new dd4t version or a new Tridion version.

The rest I am willing to consider if you trim down the PR.

NIkonDSL commented 2 years ago

never mind. I left SDL/RWS so no worries anymore

сб, 15 січ. 2022 р. о 14:31 RaimondKempees @.***> пише:

This PR is too big. I don't want to add JsonIgnoreProperties everywhere, as all properties are known and explicit, so we catch new properties early (aka a new dd4t version or a new Tridion version.

The rest I am willing to consider if you trim down the PR.

— Reply to this email directly, view it on GitHub https://github.com/dd4t/dd4t-2-java/pull/122#issuecomment-1013674449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIMWYY2VJ4RYZCJMP5VRPWTUWFSLFANCNFSM4SHAQ6BA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>