search

dd4t / dd4t-2-java

10 stars 21 forks source link

Set IsDynamic on TridionViewModelBase #82

Closed quirijnslings closed 7 years ago

quirijnslings commented 7 years ago

Currently the viewmodels do not know whether they are created from an embedded or a dynamic component presentation. This makes it hard to write out the correct XPM markup. There is a work-around in the XPMComponentPresentationTag class: it reads the 'isDynamic' value from an attribute on the request. I think that is quite ugly. Also, it makes it hard to port the tag to Thymeleaf (which is what I am doing at the moment). Would it be possible to set the isDynamic property on the entity (TridionViewModelBase) during the databinding proccess?

RaimondKempees commented 7 years ago

That's possible. It will be put in 2.0.7.

On Wed, Nov 23, 2016 at 2:16 PM, Quirijn notifications@github.com wrote:

Assigned #82 https://github.com/dd4t/dd4t-2-java/issues/82 to @RaimondKempees https://github.com/RaimondKempees.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dd4t/dd4t-2-java/issues/82#event-869672736, or mute the thread https://github.com/notifications/unsubscribe-auth/AD7xsavuTU-coP-3KhrnkGYVsKZB3-mCks5rBDyngaJpZM4K6kGJ .