ddakebono / PalworldRcon

Simple WPF/.net 7 Rcon tool for Palworld Dedicated Servers
MIT License
60 stars 8 forks source link

Windows Registry #10

Open Peep opened 6 months ago

Peep commented 6 months ago

https://github.com/ddakebono/PalworldRcon/blob/52e6c9f1a9ad66dbf55184de651e911f064cae2e/PalworldRcon/Logic/Settings.cs#L17

I don't think we should write/use the Windows registry for this kind of program -- and this does fail on some systems. Maybe writing into %userprofile%/AppData would be superior?

I can follow up with a pull request if I get some time, just wanted to mention this.

MitoG commented 6 months ago

yeah, writting to the registry, especially writing a clear text password seems like a really bad idea