ddalcino / aqt-list-server

A React SPA that replicates the function of `aqt list-*`, written in Typescript
https://ddalcino.github.io/aqt-list-server/
MIT License
20 stars 2 forks source link

Checking "Check all" for modules breaks State #10

Closed ddalcino closed 1 year ago

ddalcino commented 1 year ago

Checking "Check all" for modules alters State in a way that turns Module objects into String objects, which breaks output in the "Copy to Clipboard" section.

The result of this is that the "Your jurplel/install-qt-action yml:" and "Your aqt install command:" output sections, which the program suggests that you copy into your GitHub workflow or your terminal, prints the wrong thing. The "modules" section turns into a list of module descriptions, and not the names of the modules, resulting in a broken aqtinstall command.

Example:

The correct command:

    - name: Install Qt
      uses: jurplel/install-qt-action@v3
      with:
        aqtversion: '==2.1.*'
        version: '6.5.0'
        host: 'mac'
        target: 'desktop'
        arch: 'clang_64'
        modules: all

... becomes:

    - name: Install Qt
      uses: jurplel/install-qt-action@v3
      with:
        aqtversion: '==2.1.*'
        version: '6.5.0'
        host: 'mac'
        target: 'desktop'
        arch: 'clang_64'
        modules: 'Qt 3D Module for macOS Qt Charts for macOS Qt Connectivity for macOS Qt Data Visualization for macOS Qt Protobuf and Qt GRPC for macOS Qt HTTP Server for macOS Qt Image Formats for macOS Qt language Server for macOS Qt Location Qt Lottie Animation for macOS Qt Multimedia for macOS Qt Network Authorization for macOS Qt PDF for macOS Qt Positioning for macOS Quick: 3D Physics for macOS Qt Quick Effect Maker Qt Remote Objects for macOS Qt State Machine for macOS Qt Sensors for macOS Qt SerialBus for macOS Qt SerialPort for macOS Qt Speech for macOS Qt Virtual Keyboard for macOS Qt WebChannel for macOS Qt WebEngine for macOS Qt WebSockets for macOS Qt WebView for macOS Desktop Clang 64-bit Debug Information Files Qt 5 Compatibility Module for macOS Qt Quick 3D for macOS Qt Quick Timeline for macOS Qt Shader Tools for macOS'
ddalcino commented 1 year ago

This really needs better tests.