ddalcino / aqt-list-server

A React SPA that replicates the function of `aqt list-*`, written in Typescript
https://ddalcino.github.io/aqt-list-server/
MIT License
20 stars 2 forks source link

jurplel/install-qt-action yml doesn't work #18

Closed tim-gromeyer closed 1 year ago

tim-gromeyer commented 1 year ago

Hello, thank you for this amazing project! After I selected everything I need it generates me following jurpel/install-qt-action yml:

    - name: Install Qt
      uses: jurplel/install-qt-action@v3
      with:
        aqtversion: '==3.1.*'
        version: '6.5.0'
        host: 'mac'
        target: 'desktop'
        arch: 'clang_64'
        modules: 'qtimageformats qtmultimedia qtspeech'

but this doesn't work. I'll fail with following error:

RROR: Cannot install aqtinstall==3.1.0, aqtinstall==3.1.1, aqtinstall==3.1.2, aqtinstall==3.1.3 and py7zr==0.19.* because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested py7zr==0.19.*
    aqtinstall 3.1.3 depends on py7zr>=0.20.2
    The user requested py7zr==0.19.*
    aqtinstall 3.1.2 depends on py7zr>=0.20.2
    The user requested py7zr==0.19.*
    aqtinstall 3.1.1 depends on py7zr>=0.20.2
    The user requested py7zr==0.19.*
    aqtinstall 3.1.0 depends on py7zr>=0.20.2

This is because by default jurplel/install-qt-action uses py7zr==0.19.* but aqlinstall needs py7zr>=0.20.2 or above.
By adding py7zrversion: '>=0.20.2' to the workflow the error gets fixed.

ddalcino commented 1 year ago

Thanks for the bug report, this is worth addressing.

The root cause of this issue is tracked here: https://github.com/jurplel/install-qt-action/issues/176 . I would prefer that this problem were fixed in install-qt-action, because it affects everyone using the newer versions of aqtinstall, and ideally this project should not need to mention py7zr at all.

However, you are correct that this project needs to output working yml, no matter what. You’re welcome to make a PR if I don’t get to it first.

tim-gromeyer commented 1 year ago

The root cause of this issue is tracked here: jurplel/install-qt-action#176 . I would prefer that this problem were fixed in install-qt-action, because it affects everyone using the newer versions of aqtinstall, and ideally this project should not need to mention py7zr at all.

I agree with you wholeheartedly. This should definitely fixed in jurplel/install-qt-action

ddalcino commented 1 year ago

OK, I hope #19 fixes the issue. Please let me know if there's any situation where it's still broken.