search

ddalthorp / GenEst

R package development for a generalized mortality estimator
Other
6 stars 6 forks source link

k ~ 1 #470

Closed mhuso closed 6 years ago

mhuso commented 6 years ago

I thought we addressed this, but it seems to have come back. This notation means something to R users, but not necessarily most of our GUI users. To the untrained eye it looks like k is fixed at 1 rather than a constant. Can we change this to something less likely to be misconstrued? k ~ constant isn't necessarily very elegant, but it's better than k ~ 1 to me.

ddalthorp commented 6 years ago

We talked about using "k ~ constant" in the GUI output, but it never made it into the "issues" and fell through the cracks.

mhuso commented 6 years ago

OK. Thanks.

juniperlsimonis commented 6 years ago

ugh, shoot, no this was fixed and then i accidentally reverted during the run up to the initial release when i started some stuff back over with the app. my bad!

ddalthorp commented 6 years ago

I presume this is not difficult to fix in the GUI, but it will take some work to adjust for in the User Guide (I'll do it once the GUI is up to date), but it should be done. The few hours delay in doing the updates today before release of v0.2.0 are probably worth it because this may be going out to a lot of people (and it needs to be done before v1.0.0 in any case).

ddalthorp commented 6 years ago

The solution should probably be limited to the display of the models on the shiny side. The command line functions and model names should remain R-compatible.

juniperlsimonis commented 6 years ago

do you want the changes to be reflected in the figures, as well, but only when in the app? (i would think so, just wanted to double check)

mhuso commented 6 years ago

Yes please.

From: Juniper Simonis notifications@github.com Sent: Wednesday, August 29, 2018 2:26 PM To: ddalthorp/GenEst GenEst@noreply.github.com Cc: Manuela Huso mhuso@usgs.gov; Author author@noreply.github.com Subject: [EXTERNAL] Re: [ddalthorp/GenEst] k ~ 1 (#470)

do you want the changes to be reflected in the figures, as well, but only when in the app? (i would think so, just wanted to double check)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ddalthorp/GenEst/issues/470#issuecomment-417111453, or mute the thread https://github.com/notifications/unsubscribe-auth/AcwzAw43WvILcFFIjxQPNpJ5SQ7-uUuVks5uVwb7gaJpZM4WICT3 .[image: Image removed by sender.]

juniperlsimonis commented 6 years ago

addressed in v 0.1.9