search

ddalthorp / GenEst

R package development for a generalized mortality estimator
Other
6 stars 6 forks source link

'deployment' folder? #534

Closed ddalthorp closed 6 years ago

ddalthorp commented 6 years ago

This is a permanent feature or just there for the beta2 review process?

juniperlsimonis commented 6 years ago

are we planning to have a permanent web deployment on west's shiny server @prabie or anywhere else? if so, we should retain the folder. it's listed within the .Rbuildignore file, so it won't be built into the R package.

prabie commented 6 years ago

Yes, WEST is planning to continue to host GenEst after release.

juniperlsimonis commented 6 years ago

i thought so. then yes, this is a permanent feature.

ddalthorp commented 6 years ago

OK, but we need to remove the pdf's and the extdata.zip. Also, is there a way to have just one folder with all the logos and genest.png instead of two?

juniperlsimonis commented 6 years ago

the deployment folder will get updated once everything else is all ready and no, those need to be in two separate places, one for each version of the app

juniperlsimonis commented 6 years ago

updated in #547 v 0.2.9