search

ddalthorp / GenEst

R package development for a generalized mortality estimator
Other
6 stars 6 forks source link

proper tests for all functions #568

Open juniperlsimonis opened 6 years ago

juniperlsimonis commented 6 years ago

the command line functions should all have tests http://r-pkgs.had.co.nz/tests.html

juniperlsimonis commented 6 years ago

@ddalthorp can you tackle writing the tests for the command line functions? i'm working on all of the UI functions with the tidying up I'm doing. the examples that are in the documentation actually provided a pretty good set of tests, they just need to be integrated into the testing structure like everything else.

ddalthorp commented 6 years ago

The vignettes provide a great test, especially if we read through them after significant changes, which I'm planning to do in the next day or so.

juniperlsimonis commented 6 years ago

Yes that's true, but the vignettes aren't proper unit tests.

juniperlsimonis commented 6 years ago

this is a really great overview of testing across a codebase: https://katyhuff.github.io/python-testing/