Closed mhuso closed 5 years ago
the upload type is flexible file-by-file, so there'd need to be a rule or button to handle when someone uploads some of each.
How about download in same format as the first upload?
right, that's a rule to handle the upload of each (which is first, what happens when clears, etc etc) this is totally doable, but even something like that will take quite a bit of traffic directing.
That works for me!
From: ddalthorp notifications@github.com Sent: Wednesday, September 26, 2018 8:07 PM To: ddalthorp/GenEst GenEst@noreply.github.com Cc: Manuela Huso mhuso@usgs.gov; Author author@noreply.github.com Subject: [EXTERNAL] Re: [ddalthorp/GenEst] Output csv's in same format as input (#569)
How about download in same format as the first upload?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ddalthorp/GenEst/issues/569#issuecomment-424943663, or mute the thread https://github.com/notifications/unsubscribe-auth/AcwzAxiK4Ujs8-TelVXDfMxyBuOvhN7Vks5ufEDXgaJpZM4W7kYn .[image: Image removed by sender.]
Downloaded .csv's will have format of the last uploaded .csv. [It's easier to track the data that way...and also makes more sense than matching the first one]
Sounds good!
From: ddalthorp notifications@github.com Sent: Thursday, September 27, 2018 2:06 PM To: ddalthorp/GenEst GenEst@noreply.github.com Cc: Manuela Huso mhuso@usgs.gov; Author author@noreply.github.com Subject: [EXTERNAL] Re: [ddalthorp/GenEst] Output csv's in same format as input (#569)
Downloaded .csv's will have format of the last uploaded .csv. [It's easier to track the data that way...and also makes more sense than matching the first one]
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ddalthorp/GenEst/issues/569#issuecomment-425243190, or mute the thread https://github.com/notifications/unsubscribe-auth/AcwzA0JY8ao6_ZW8PcTt-YW0cID_rBaPks5ufT3MgaJpZM4W7kYn .[image: Image removed by sender.]
dan did you do this already? you closed the issue but i don't see associated changes to the code (unless i'm missing something?)
Yep. It's on the "dan" branch...doing some other stuff first before pushing.
great! if it's done then, can you please push that code in? i'm going to be working on the GUI scripts here shortly and want to avoid conflicted copies
OK. I need to run a few tests first...but I'll get right on it.
great, thanks! also I just looked over at that branch and wanted to request that you please do not delete functions like makeEstText
, as the point of them is to explicitly reduce line breaks in code in the higher level functions and minimize the locations of code that need to be edited. if you want to change the text, just change it in the function. if it needs to be different between SE and CP, just add a toggle argument to the function. that's the whole goal of those small functions, to keep the code you need to actually read at any one spot to a minimum, and i spent a lot of time doing that so it will be easy to edit in one place (i.e. the function). thanks!
also, out of curiosity, what happens if someone clears a data file? like say i upload everything as csv, but the last one as csv2, realize my mistake, clear it, and reload a csv?
If user uses "European" csv, output should also be "European" This brings up another point... can one input file be "American" and another "European?"