search

ddalthorp / GenEst

R package development for a generalized mortality estimator
Other
6 stars 6 forks source link

search box on tables? #582

Closed ddalthorp closed 6 years ago

ddalthorp commented 6 years ago

This is puzzling. What's it for? Can we remove it?

E.g.: image

juniperlsimonis commented 6 years ago

you can use it to search the table. and that's part of the data table output structure yes we can remove it if we want https://rstudio.github.io/DT/options.html

ddalthorp commented 6 years ago

What would we want to search for in a necessarily short table?

juniperlsimonis commented 6 years ago

IDK, it's in there by default, so i've left it in. if you have a long list of models it can definitely be helpful, same if you have a long list of data in a file.

ddalthorp commented 6 years ago

I wouldn't want to take it out if people would find it useful, but I'm just not seeing how it would be helpful with a long list of models (which is still a short table...).

ddalthorp commented 6 years ago

let's keep it.

juniperlsimonis commented 6 years ago

something that is surely doable, but low enough of a priority to wait until v 2 given the situation, is making it dynamic, such that only tables long enough to be cut off to another "page" (where you have to click through the table at the bottom) get a "search" field.

ddalthorp commented 6 years ago

I meant...let's keep it the way it is.

99% of the time it will be ignored, but there is a (somewhat obscure) use for it.