search

ddalthorp / GenEst

R package development for a generalized mortality estimator
Other
6 stars 6 forks source link

v 0.3.1 UI refactor #584

Closed juniperlsimonis closed 6 years ago

juniperlsimonis commented 6 years ago

version 0.3.1 is a major step in the refactor of the front-end (user interface) code. the tidying of the GUI codebase is a work in progress and will continue, but the work is at a good point (covering the UI code) and the code is stable, so i am merging the work into the master branch.

primarily, much of the code chunks/functions that are very similar are being condensed into a set of few, flexible/generalized functions. this reduces the code clutter and the number of edit points in the code base. associated with the code tidying is substantial work on the documentation, such that aligned functions within the GUI codebase are now being documented together. in addition, there is a new (in development/draft) vignette describing the GUI codebase. currently, it is focused on the user interface, as that's where the refactor has hit so far. as the code base is tightened, additional information will be added to that vignette.

we are now incorporating a more rigorous set of code tests, thus far focused on the data loading and the functions that have been touched by the refactor. there is much testing still to include, but this is a good start.

this PR includes the edits of #581 (that PR can be closed)

ddalthorp commented 6 years ago

This update is MUCH easier to follow than the previous. Thanks!

juniperlsimonis commented 6 years ago

for sure! the goal is to keep heading in this direction. the order has always been [1] make it work [2] make it look pretty for the user [3] make it look pretty behind the scenes.

all of the server functions (update____) can get a similar tidying, now that we have the set of routines ironed out. it'll take a fair amount of time, and i'll chip away at it as i can