ddalthorp / GenEst

R package development for a generalized mortality estimator
Other
6 stars 6 forks source link

Possible to get NaN values for g with some data sets #591

Closed prabie closed 6 years ago

prabie commented 6 years ago

Confidential data set shared with Juniper and Dan.

ddalthorp commented 6 years ago

A few issues... 1) the dates were not formatted properly. The program required dates to be yyyy-mm-dd or mm/dd/yyyy, but the data set had yyyy/mm/dd. The new version (0.3.5) has greater flexibility on dates (including allowing yyyy/mm/dd).

2) Search dates are assumed to be in increasing order, but there was no check on that. I put in a check. The SS data had some errors in it. In particular, the SS dates should probably have the following corrections

data_SS$Date[4]   <- "2016/04/17"
data_SS$Date[104] <- "2016/09/28"
data_SS$Date[242] <- "2017/05/05"

With the corrections to the data and the more flexible date parsing, I had no trouble running the data set.

prabie commented 6 years ago

Thanks, Dan. Funny, I thought I'd sorted the SS table on date but I must be mistaken. I also am able to generate estimates.

Western EcoSystems Technology, Inc. Environmental & Statistical Consultants 200 S. Second Street Laramie, WY 82070 307-755-9447 www.west-inc.com

Follow WEST: Facebook http://www.facebook.com/pages/Western%E2%80%90EcoSystems%E2%80%90Technology%E2%80%90WESTInc/125604770807646 , Twitter http://twitter.com/WestEcoSystems, Linked In http://www.linkedin.com/company/1458419, Join our Mailing list http://visitor.r20.constantcontact.com/manage/optin/ea?v=001qrD4A3S5xJ5KgMyelH9jyw%3D%3D

CONFIDENTIALITY NOTICE: This message and any accompanying communications are covered by the Electronic Communications Privacy Act, 18 U.S.C. §§ 2510-2521, and contain information that is privileged, confidential or otherwise protected from disclosure. If you are not the intended recipient or an agent responsible for delivering the communication to the intended recipient, you are hereby notified that you have received this communication in error. Dissemination, distribution or copying of this e-mail or the information herein by anyone other than the intended recipient, or an employee or agent responsible for delivering the message to the intended recipient, is prohibited. If you have received this communication in error, please notify us immediately by e-mail and delete the original message. Thank you.

P Please consider the environment before printing.

On Tue, Oct 2, 2018 at 11:34 PM ddalthorp notifications@github.com wrote:

A few issues...

1.

the dates were not formatted properly. The program required dates to be yyyy-mm-dd or mm/dd/yyyy, but the data set had yyyy/mm/dd. The new version (0.3.5) has greater flexibility on dates (including allowing yyyy/mm/dd). 2.

Search dates are assumed to be in increasing order, but there was no check on that. I put in a check. The SS data had some errors in it. In particular, the SS dates should probably have the following corrections

data_SS$Date[4] <- "2016/04/17" data_SS$Date[104] <- "2016/09/28" data_SS$Date[242] <- "2017/05/05"

With the corrections to the data and the more flexible date parsing, I had no trouble running the data set.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ddalthorp/GenEst/issues/591#issuecomment-426516910, or mute the thread https://github.com/notifications/unsubscribe-auth/Acw22trQv66T8Ot1fYGP6sf4hZe2BgbBks5uhExXgaJpZM4XEXyx .