search

ddalthorp / GenEst

R package development for a generalized mortality estimator
Other
6 stars 6 forks source link

matrixStats: Upcoming version requires using useNames = TRUE in two places #657

Closed HenrikBengtsson closed 1 year ago

HenrikBengtsson commented 1 year ago

Hello. The matrixStats package will soon be updated to output row and column names consistently. The current behavior is useNames = NA for backward compatibility, but we'll switch to useNames = FALSE soon, cf. https://github.com/HenrikBengtsson/matrixStats/issues/226.

The switch to useNames = FALSE will break GenEst. I've created PR #656 that fixes this. All that was needed is to specify useNames = TRUE in summary.splitFull() in two places.

PS. I noticed that you submitted GenEst 1.4.7 to CRAN just two hours ago. What's the chance for that? Oh, well. If you happen to get a pushback on that submission, please consider incorporating this PR in your resubmission.

ddalthorp commented 1 year ago

Henrik, this is great.

Thanks for your help on suggestions for making GenEst work with the new matrixStats.

Your work goes above and beyond the call of duty.

Much appreciated.

-Dan ------- Original Message ------- On Monday, November 14th, 2022 at 7:06 PM, Henrik Bengtsson @.***> wrote:

Hello. The matrixStats package will soon be updated to output row and column names consistently. The current behavior is useNames = NA for backward compatibility, but we'll switch to useNames = FALSE soon, cf. HenrikBengtsson/matrixStats#226.

The switch to useNames = FALSE will break GenEst. I've created PR #656 that fixes this. All that was needed is to specify useNames = TRUE in summary.splitFull() in two places.

PS. I noticed that you submitted GenEst 1.4.7 just two hours ago. What's the chance for that? Oh, well. If you happen to get a pushback on that submission, please consider incorporating this PR in your resubmission.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

HenrikBengtsson commented 1 year ago

I see a commit on this. Do you have an ETA for submitting this to CRAN?

ddalthorp commented 1 year ago

23 Nov 2022

------- Original Message ------- On Wednesday, January 11th, 2023 at 7:10 AM, Henrik Bengtsson @.***> wrote:

I see a commit on this. Do you have an ETA for submitting this to CRAN?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

HenrikBengtsson commented 1 year ago

Oh, so you're saying it's already on CRAN. I missed that because this issue was still open.