search

ddarriba / modeltest

Best-fit model selection
GNU General Public License v3.0
72 stars 21 forks source link

Assertion failed in modeltest::ParameterGamma::optimize #21

Closed BenoitMorel closed 5 years ago

BenoitMorel commented 5 years ago

Hi Diego and all,

I am running modeltest-ng 0.1.5 on a quite large alignment. As suggested by Diego, I split the partition file into 10 subfiles and started 10 separate jobs (although I don't think it's related to my issue), to fit the memory. All the 10 jobs failed on the same assertion:

modeltest-mpi: ../src/model/parameter_gamma.cpp:100: double modeltest::ParameterGamma::optimize(modeltest::mt_opt_params_t *, double, double, bool): Assertion     `!loglh || (cur_loglh - loglh)/loglh <= 1e-10' failed.

I recently successfully ran modeltest-ng on the same dataset with the same splitting strategy. The only difference is that I added the models LG4M and LG4X to the analysis that failed.

Any idea about what could be wrong? If yes, is there any quick workaround I could use? (like removing or relaxing the assert)

Cheers, Benoit

BenoitMorel commented 5 years ago

Since the dataset was too big to allow you to reproduce, I ran modeltest on each partition separately, to find the guilty ones. I did not reproduce the bug. I will close the issue and reopen it if this happens again.