search

ddavid / fsoco

Formula Student Objects in Context Dataset for the Formula Student Driverless competitions
Apache License 2.0
57 stars 53 forks source link

Dynamis PRC dataset submission #35

Closed manderino1 closed 5 years ago

ddavid commented 5 years ago

Hi Marco, everything is looking pretty good. There is one small issue, the big yellow cones in the data set are not labeled as seen in the attached image image 448. Could you please add labels for the images with big yellow cones and add the class to the classes index text file?

manderino1 commented 5 years ago

Yes sure, i'll do that this afternoon and commit the changes. Thank you

Il mar 26 nov 2019, 14:07 David Dodel notifications@github.com ha scritto:

Hi Marco, everything is looking pretty good. There is one small issue, the big yellow cones in the data set are not labeled as seen in the attached image [image: image 448] https://user-images.githubusercontent.com/18621443/69636055-0c6e2b80-1056-11ea-8e47-89546898c025.jpg . Could you please add labels for the images with big yellow cones and add the class to the classes index text file?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ddavid/fsoco/pull/35?email_source=notifications&email_token=AKRQKLS6AWH4YLUW26LU6WLQVUNR5A5CNFSM4JMCJVZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFF53KI#issuecomment-558620073, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKRQKLVH5HHS72E6LNP2R5LQVUNR5ANCNFSM4JMCJVZQ .

manderino1 commented 5 years ago

Hi, i added the class and the cones as requested and also added some missing cones of the other class. I also updated the number of cones in the documentation. Tell me if there is something else to fix of it's ok now. Thank you

ddavid commented 5 years ago

Hi Marco, sorry for the late reply, only came around to take a look at the changes today. Thank you for making the corrections! There's just one last thing, are the cones seen in this picture consistently labeled as orange-cones throughout the data set? I ask because in the context of the FSD competitions in Europe, one would assume them to be the big-orange-cones that are in your classes file.

boxes_431

manderino1 commented 5 years ago

Yes, we labelled them all as orange-cones but I can change it if you want them consistent to the other datasets Just tell me if you prefer and I'll change all the orange-cone class to big-orange-cone

ddavid commented 5 years ago

Yes, please do change them, as this could lead to some very weirdly performing models and it's hard to document. Will go through the changes tomorrow morning.

manderino1 commented 5 years ago

Ok I did it, it should be ok now

ddavid commented 5 years ago

Looks good to go. Thank you for your contribution!