ddavid / fsoco

Formula Student Objects in Context Dataset for the Formula Student Driverless competitions
Apache License 2.0
57 stars 53 forks source link

feat(*): added FaSTDa labels and updated docs #69

Closed lukaskoenen closed 4 years ago

lukaskoenen commented 4 years ago

Initial FaSTDa-Racing lables and Documentation for Review.

ddavid commented 4 years ago

Hey there Lukas, firstly the quality of the labels is great on the whole, good job! It looks like your team had a lot of fun while creating the first samples.

There's a few things before merging though:

boxes_image330 boxes_image608 For the skid-pad images you've labeled even the smallest of cones, but for the sequence coming into and back from Acceleration a lot of cones that look similar are left out. I'd consider keeping the latter out of your dataset, if you're still above the 600 image contribution threshold without them.

boxes_image759 Along with 817 and 818, I'd expect you to label the cones being carried from how you labeled the rest.

Another point is the small orange/red cones from the FSS and FSG footage. I'm afraid those would need to be labeled as otherwise it would be hard to use the dataset together with others. Not having those classes is possible, as long as they don't appear in the dataset's images. The blue-cones in FSS are different enough to be disregarded, since they don't have the white stripe and the hue is quite different.

Lastly, there were a few labels that were mal-formatted. Maybe something went wrong when parsing them? mal-formatted.txt

lukaskoenen commented 4 years ago

Hi there David, first of all thanks for the detailed feedback. We will look at the problems mentioned above and then provide an updated one. Thanks again and have a nice Easter.

lukaskoenen commented 4 years ago

Hi David we hopefully fixed the errors concerning the Dataset. Google Album should be updated aswell.

ddavid commented 4 years ago

Hi Lukas, thanks for the update. I'm a bit short on time this week because of a practical course at the university, but I'll let you know as soon as I've had the chance to go through the changes.

ddavid commented 4 years ago

Unfortunately didn't work out last week. Tomorrow should work :+1:

ddavid commented 4 years ago

Hi Lukas, the contribution looks excellent! Thank you for putting the extra effort in with the additional small orange cones for the FS Austria and FSG images. There are just a few labeling mistakes that crept in with the update:

lukaskoenen commented 4 years ago

Hi David, thank you, I will take care of fixing the mistakes. I will write a comment again when the frok is updated.

lukaskoenen commented 4 years ago

Hi David should all be fixed now.

ddavid commented 4 years ago

I'm sorry, I did not see the comment. I will finish it up tomorrow, please excuse the delay.

ddavid commented 4 years ago

Perfect, the changes to the last three problematic images look great. Thank you for your contribution.