search

ddavison / rest-client

A simple REST client for the Atom editor!
http://atom.io/packages/rest-client
MIT License
53 stars 29 forks source link

Refactor class/id interpolation #67

Closed jonatanklosko closed 8 years ago

jonatanklosko commented 8 years ago

I think that this decreases the complexity =) Basically for both class and id there was .split('.')[1]} and .split('#')[1]} accordingly. Now it's just a method all that removed the first character. Maybe you will came up with a better name? =)

ddavison commented 8 years ago

i agree that the way i set this up originally is really stupid.. splitting on everything. having this would make it readable. thanks! keep it up!

jonatanklosko commented 8 years ago

name_of is indeed nicer, I've updated the code. Btw. is there any case convention? I see both camel and snake here.

ddavison commented 8 years ago

I think i'd prefer snake_case rather than camelCase in CoffeeScript. i'll edit the CONTRIBUTING.md sometime to include that

ddavison commented 8 years ago

but you're right.. go ahead and do it camelCase since the other methods are that way

EDIT: sorry, just realized you committed again to change it to snake case 🤐

jonatanklosko commented 8 years ago

No problem it's just a quick replacement. I updated to camelCase, I hope that's what you wanted =)

ddavison commented 8 years ago

hey @jonatanklosko , could you rebase and fix the conflicts please? then i'll push up a release 👍

jonatanklosko commented 8 years ago

Done!