search

ddavisqa / google-refine

Automatically exported from code.google.com/p/google-refine
0 stars 0 forks source link

Add support for ownText from JSoup #338

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
To support Jsoup Element.ownText()

Original issue reported on code.google.com by thadguidry on 23 Feb 2011 at 5:14

Attachments:

GoogleCodeExporter commented 8 years ago 
Also attached corresponding new OwnText.java file

Verified as working correctly.

Screenshots:
when htmlText() is used - http://awesomescreenshot.com/05a836s29
when ownText() is used - http://awesomescreenshot.com/017836z10

Original comment by thadguidry on 23 Feb 2011 at 5:30

Attachments:

GoogleCodeExporter commented 8 years ago 
I'll apply this.  A couple of suggestions for the future:
- create a single patch file containing both the modified and new module, that 
way it can all be applied at once.
- use a test case that shows a difference in the output of the two functions 
(because there are no contained elements in your example, both functions return 
the same text)

Original comment by tfmorris on 23 Feb 2011 at 7:29

GoogleCodeExporter commented 8 years ago 
Patch applied in r2025

Original comment by tfmorris on 23 Feb 2011 at 7:41

GoogleCodeExporter commented 8 years ago 
re: single patch file.  Do you mean a .zip that has the files I modified in it ?

re: test case.  I thought both screenshots showed the difference well between 
htmlText() and ownText() ?  Can you explain more ?

Original comment by thadguidry on 23 Feb 2011 at 7:50

GoogleCodeExporter commented 8 years ago 
My bad on the test.  I looked at the screenshots four times, but I guess I 
should have opened them side by side rather than looking at them alternately.

For the patch, just diff the whole project or directory, the new module will 
get included in the patch as one giant addition.  That way the patch can be 
applied as a unit without any hand fiddling and we'll be sure everything is 
just the way you intended.  It's both more reliable and less work.

Original comment by tfmorris on 23 Feb 2011 at 8:15

GoogleCodeExporter commented 8 years ago 
1. No idea how to diff the whole project (although I understand the intent), 
use a tool for diff'ing ?  Use SVN diff ?  To me, a quick patch was exactly how 
I handled it, but welcome your comments, Tom.  Perhaps in a separate email 
thread.
2. I'm a novice altogether with programming, if you recall, but try where I 
can.  This was the best I could do in a pinch.  I think it's safer to just 
email stuff directly to you or David later on. (Although I like the edit 
ability within Google Code)

Original comment by thadguidry on 23 Feb 2011 at 8:35

GoogleCodeExporter commented 8 years ago 
Not sure how to wire up for an additional error here, but I think it is needed ?

http://awesomescreenshot.com/08683st19

Can you help with that Tom ?

Original comment by thadguidry on 23 Feb 2011 at 10:47

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 9 Jun 2011 at 8:03