ddavisqa / google-refine

Automatically exported from code.google.com/p/google-refine
0 stars 0 forks source link

won't run if there's a systemwide proxy #360

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Install and run privoxy systemwide
2. ./refine run

What is the expected output? What do you see instead?

I expect google-refine to open in a new browser tab. Instead, I get one line of 
output stating "Google Refine is already running." and I am dumped back to the 
command line.

What version of Google Refine are you using?

2.0

What operating system and browser are you using?

Ubuntu Linux 10.04.2, minefield web browser.

Is this problem specific to the type of browser you're using or it happens
in all the browsers you tried?

It is not related to the browser.

Please provide any additional information below.

It looks to me like the problem happens in the "refine" bash script on line 
153. The NOT_RUNNING variable gets set only if the curl or wget command returns 
anything other than 0 (I think, happy to be corrected.) This leads, later on in 
the same file on line 594 to the script thinking that refine is already running 
since NOT_RUNNING was not set (the double negative there might indicate that 
refactoring how that bit is performed might be clever :) ) so you get that nice 
warn on the console and it dumps you out to the command line.

A lock file might be the way to go here; alternatively, line 153 could look 
like:

NOT_RUNNING=`curl -s -I $URL | egrep "200\ OK" > /dev/null || echo not_running`

and line 155 would look like:

NOT_RUNNING=`wget -q -O - $URL | egrep "200\ OK" > /dev/null || echo 
not_running`

The idea here obviously is that we consider anything other than a 200 OK http 
status on the refine front page URL to be a sign it isn't running.

The drawback being the introduction of a new egrep dependency. It also assumes 
the proxy behaves properly and throws a non-200 http status.

Original issue reported on code.google.com by josef.as...@gmail.com on 13 Apr 2011 at 4:48

GoogleCodeExporter commented 8 years ago
I suspect that the fixes for issue 325 and issue 262 will help here.  Please 
test with the 2.1 release candidate and let us know if it resolves your problem.

Original comment by tfmorris on 10 Jun 2011 at 10:39

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 10 Jun 2011 at 10:40

GoogleCodeExporter commented 8 years ago
Since there's been no feedback in three months, I'm closing this.  Feel free to 
reopen it if the problem is reproduceable with the current v2.1 release.

Original comment by tfmorris on 22 Sep 2011 at 10:33