search

ddavisqa / google-refine

Automatically exported from code.google.com/p/google-refine
0 stars 0 forks source link

Build is broken #364

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Can't compile latest r2043. Many errors about invalid chars in Metaphone3.java. 
See attached log for details.

Original issue reported on code.google.com by techtonik@gmail.com on 16 Apr 2011 at 4:08

Attachments:

GoogleCodeExporter commented 8 years ago 
This is likely a platform-specific problem for platforms which don't have UTF-8 
as their default character encoding.  The current build assumes, but doesn't 
specify, UTF-8.

Original comment by tfmorris on 16 Apr 2011 at 7:25

GoogleCodeExporter commented 8 years ago 
I am on Windows.

Original comment by techtonik@gmail.com on 16 Apr 2011 at 7:30

GoogleCodeExporter commented 8 years ago 
Vista Home edition, JDK 1.6.0_24. Attached patch fixes the issue.

Original comment by techtonik@gmail.com on 16 Apr 2011 at 7:40

Attachments:

GoogleCodeExporter commented 8 years ago 
It was working on the Mac, but broken on Linux. I "fixed" it for Linux, but 
re-encoding that file. But then it's broken on the Mac now. I'm guessing that 
we have to explicitly escape those international characters.

Original comment by dfhu...@gmail.com on 17 Apr 2011 at 3:44

GoogleCodeExporter commented 8 years ago 
Depending on a platform's default character encoding doesn't really work since 
they all differ.

I had already changed the Eclipse project definition and now I've changed the 
Ant build files to specify utf-8 as the source file character encoding.  So, 
for now, UTF-8 is the mandated character encoding for all source files. We can 
change this to something else, but it should be the same for all platforms.

Original comment by tfmorris on 17 Apr 2011 at 4:42

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 18 Sep 2012 at 3:01