Use ==/!= to compare str, bytes, and int literals - Githubissues

ddbourgin / numpy-ml

Machine learning, in numpy

https://numpy-ml.readthedocs.io/

GNU General Public License v3.0

15.35k stars 3.72k forks source link

Use ==/!= to compare str, bytes, and int literals #43

Closed cclauss closed 3 years ago

cclauss commented 4 years ago

Identity is not the same thing as equality in Python so use ==/!= to compare str, bytes, and int literals. In Python >= 3.8, these instances will raise SyntaxWarnings so it is best to fix them now. https://docs.python.org/3.8/whatsnew/3.8.html#porting-to-python-3-8

All Submissions

[x] Is the code you are submitting your own work?
[ ] Have you followed the contributing guidelines?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Model Submissions

[ ] Is the code you are submitting your own work?
[ ] Did you properly attribute the authors of any code you referenced?
[ ] Did you write unit tests for your new model?
[ ] Does your submission pass the unit tests?
[ ] Did you write documentation for your new model?
[ ] Have you formatted your code using the black deaults?

Changes to Existing Models

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?