Fixed bug in layers.set_params() - Githubissues

ddbourgin / numpy-ml

Machine learning, in numpy

https://numpy-ml.readthedocs.io/

GNU General Public License v3.0

15.26k stars 3.7k forks source link

Fixed bug in layers.set_params() #62

Closed RaulMurillo closed 3 years ago

RaulMurillo commented 3 years ago

All Submissions

[x] Is the code you are submitting your own work?
[x] Have you followed the contributing guidelines?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Model Submissions

[ ] Is the code you are submitting your own work?
[ ] Did you properly attribute the authors of any code you referenced?
[ ] Did you write unit tests for your new model?
[ ] Does your submission pass the unit tests?
[ ] Did you write documentation for your new model?
[ ] Have you formatted your code using the black deaults?

Changes to Existing Models

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

This closes #61, closes #63

RaulMurillo commented 3 years ago

Also added a commit to close #63

ddbourgin commented 3 years ago

Looks good to me! Thanks so much for catching + fixing this @RaulMurillo