Closed sfsf9797 closed 3 years ago
Amazing! At first glance this looks great, @sfsf9797 ! I'm pretty slammed with work right now, but am going to have a look at this this weekend.
Hey @sfsf9797 - Thanks for the PR! I just had a more thorough look and committed a few changes. Brief summary:
Please feel free to make adjustments or ask questions. Once we both agree on the implementation and are happy with the model performance, I'm happy to merge.
Hi, thank you so much for all the feedbacks, I will go through all these and get back to you this weekend.
sorry, I am kind of busy these few weeks, but I will get you back latest by another 2 weeks times.
Hi @ddbourgin thanks for correcting my implementation. I have learnt a lot from you. I am pretty satisfied with the model after a few round of checking. Lastly, Thank you a lot for the all the comments!
Awesome, merged! Thanks for the PR @sfsf9797 :)
Implement Gaussian naive Bayes Class and Basic documentation.
Refer to the formula of Gaussian naive Bayes from the notes
compare the performance with the gaussianNB from sci-kit learn.