Open naveen-marthala opened 2 years ago
Thanks for raising this + the comprehensive Colab notebook - I appreciate it! Yup, you're right, it looks like the "updated" version in the repo is returning the beta
transpose rather than beta
, so there's a dimension mismatch during prediction.
I'll try to push a fix for this shortly. Thanks for the heads up :)
System information
Describe the current behavior I have copy-pasted the code for
numpy_ml.linear_model.LinearRegression
from github and did.fit()
and.predict()
on some dummy data. I gotValueError
on.predict()
like this:Describe the expected behavior Expected behaviour is that
.predict()
doesn't generateValueError
.Code to reproduce the issue not code, here is the link to the notebook: https://colab.research.google.com/drive/12q9r2j4-UpUrPnzvMiPC6rxafa73cY5L?usp=sharing
Other info / logs