Closed kwedrowicz closed 5 years ago
First of all, thanks @pilloPl for great DDD example in practice 💪
During the project study, I found that not all tests are passing (which brokes CI). Guilty was double wrapping in HATEOAS compatible classes in PatronProfileController.
PatronProfileController
Actual patronProfile endpoint result:
patronProfile
{ "entity": { "_links": { "holds": { "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd/holds/" }, "checkouts": { "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd/checkouts/" }, "self": { "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd" } }, "patronId": "d969e595-1bc2-40ec-996c-90c6a396a3bd" } }
Expected result:
{ "_links": { "holds": { "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd/holds/" }, "checkouts": { "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd/checkouts/" }, "self": { "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd" } }, "patronId": "d969e595-1bc2-40ec-996c-90c6a396a3bd" }
Small fix applied 😄
Thank you so much!
First of all, thanks @pilloPl for great DDD example in practice 💪
During the project study, I found that not all tests are passing (which brokes CI). Guilty was double wrapping in HATEOAS compatible classes in
PatronProfileController
.Actual
patronProfile
endpoint result:Expected result:
Small fix applied 😄