search

ddddxxx / LyricsX

🎶 Ultimate lyrics app for macOS.
Mozilla Public License 2.0
4.71k stars 386 forks source link

No such module 'CombineX' #389

Closed JCsplash closed 4 years ago

JCsplash commented 4 years ago

Also getting no module for 'SnapKit' 'GenericID', 'DFRPrivate', 'MASShortcut', and 'Sparkle' - when building the project.

Screen Shot 2020-06-03 at 10 54 01 PM

@ddddxxx Any ideas how to fix this?

JCsplash commented 4 years ago

Just installed Carthage packages and resolved all errors except for the CombineX one. I tried re-adding CombineX to SPM but keep getting the following error.

error: unable to open dependencies file (/Users/jxchen/Library/Developer/Xcode/DerivedData/Test_SPM_Application-dgeqrgurwbmedidkyamctwmucaye/Build/Intermediates.noindex/CombineX.build/Debug/CombineX.build/Objects-normal/x86_64/Empty-PACKAGE:https://github.com/cx-org/CombineX::MAINGROUP::REF_2::REF_65.d) (in target 'CombineX' from project 'CombineX') Command CompileSwiftSources emitted errors but did not return a nonzero exit code to indicate failure

ddddxxx commented 4 years ago

CombineX has compatibility issue with Xcode 11.4+. Currently I'm using Xcode 11.3.1 to build LyricsX.

JCsplash commented 4 years ago

@ddddxxx No worries, i ended up just using Combine instead of CombineX. Love the library thank you! A few others questions if you have some time:

  1. Is there a way to import LRC files from outside of LyricsX? I’d love to be able to trigger draggedFinished or the importLyrics function from a shell script if possible.

  2. Do both UserDefaults (wrong lyrics) and Saved LRC Files (in the music folder) persist even when the app is deleted? So far they seem like they do but wanted to double check.

ddddxxx commented 4 years ago
  1. No. I'd like to add it, please file an issue.
  2. Neither of them is removed when you delete the app.
ddddxxx commented 4 years ago

Fixed in cx-org/CombineX#81. CombineX 0.2.1 now works with Xcode 11.4+.

JCsplash commented 4 years ago

@ddddxxx Thanks for the bug fix! Apologies for the late reply. I ended up writing a simple command line utility to save lyrics as lrcx files in the Music folder and it works great. Thank you again for the great library!