ddddxxx / LyricsX

🎶 Ultimate lyrics app for macOS.
Mozilla Public License 2.0
4.63k stars 382 forks source link

LyricsX needs to be restarted after each song #581

Open Ein-Tim opened 1 year ago

Ein-Tim commented 1 year ago

Environment

Describe the bug

When I start LyricsX before I start playing a song, LyricsX won't work (=won't show the lyrics). So I start LyricsX while I play a song and it will work. However, after the currently playing song ended and the next one starts, LyricsX again doesn't work and needs to be restarted.

RockTraveler commented 1 year ago

I got same situation, i belive it's a bug.

arifth commented 1 year ago

i got the same issue , need to restart lyricx after every song

JosMurray commented 1 year ago

I have the same problem than @Ein-Tim: macOS 12.6 LyricsX App Store Version 1.6.3 (2350) Spotify para macOS (Intel) 1.1.94.870.gf994cb0b

sahakaori commented 1 year ago

macOS 12.6 LyricsX App Store Version 1.6.3 iTunes also can't search Lyrics

LLuna-a commented 1 year ago

I have the same issue too macos 12.6 Apple M1

rzb-y commented 1 year ago

@ddddxxx It seems like the author is currently unavailable, and hasn't been responding to any messages sadly. I think almost everyone has this issue no matter which version

LLuna-a commented 1 year ago

i wrote an applescript that restarts it every 15 seconds if anyone interested i can post it

eiche77 commented 1 year ago

@LLuna-a it would be appreciated if you post the scripts. :)

LLuna-a commented 1 year ago

@LLuna-a it would be appreciated if you post the scripts. :)

@eiche77 https://github.com/LLuna-a/LyricsX-Temporary-Fix here I published it it's not efficient at the moment I will rework it to simply restart it beginning of a new song

LLuna-a commented 1 year ago

also, @eiche77 if you understand the apple script can you help it with the more developed version I couldn't find a way to loop it it just works once and stops

LLuna-a commented 1 year ago

any news from the developer? can someone talk to him on telegram?

Ein-Tim commented 1 year ago

@ddddxxx Can we expect a fix for this issue from your side anytime soon?

EraserCN commented 1 year ago

The same issue for me. Ventura beta 11

RadioHeadach commented 1 year ago

same

augustido commented 1 year ago

Same to me

jjaychen1e commented 1 year ago

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map:

image

LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: https://github.com/ddddxxx/LyricsKit/pull/16

LLuna-a commented 1 year ago

it seems like the problem is solved thanks to @jjaychen1e edit: sadly it only works for the songs I listened to in the past (I don't know maybe it finds new ones but I tested in a couple of songs but it couldn't find some) it does not find new lyrics but can show old ones without restarting the app

jjaychen1e commented 1 year ago

it seems like the problem is solved thanks to @jjaychen1e edit: sadly it only works for the songs I listened to in the past (I don't know maybe it finds new ones but I tested in a couple of songs but it couldn't find some) it does not find new lyrics but can show old ones without restarting the app

It's not merged and released yet, did you test it with your own build? For me, the cached lyrics work fine all the time, only new songs cannot fetch the lyrics. My commit fixes this but has not been merged.

LLuna-a commented 1 year ago

it seems like the problem is solved thanks to @jjaychen1e edit: sadly it only works for the songs I listened to in the past (I don't know maybe it finds new ones but I tested in a couple of songs but it couldn't find some) it does not find new lyrics but can show old ones without restarting the app

It's not merged and released yet, did you test it with your own build? For me, the cached lyrics work fine all the time, only new songs cannot fetch the lyrics. My commit fixes this but has not been merged.

sorry, yes I tried building my own must made a mistake its worth waiting the official merge then cached ones always had worked for me but it cached the first 2 3 ones I opened that's why i thought it worked

Gghyy commented 1 year ago

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image

LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

jjaychen1e commented 1 year ago

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Update: I've re-uploaded a universal version so it can work on both Intel and Apple Silicon Macs.

FrankYip1020 commented 1 year ago

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Could you please upload a Universal app version? This only works on Apple Silicon.

Gghyy commented 1 year ago

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Thank you very much!! That helps me a lot! 😄 😄

jjaychen1e commented 1 year ago

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Could you please upload a Universal app version? This only works on Apple Silicon.

Here is the universal version:

LyricsX.app.zip

FrankYip1020 commented 1 year ago

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Could you please upload a Universal app version? This only works on Apple Silicon.

Here is the universal version:

LyricsX.app.zip

Thanks a lot, it works on my Mac.

Jechin commented 1 year ago

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

jjaychen1e commented 1 year ago

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

Sorry, it's my mistake. I turn off other services when debug the code. Here is the updated version: LyricsX.app.zip

LLuna-a commented 1 year ago

thanks for new build it works

LightFocus commented 1 year ago

Thank you so much, it works for me!

LLuna-a commented 1 year ago

Thank you so much, it works for me!

does it still work for you? the build from @jjaychen1e stopped working for me after a while

LightFocus commented 1 year ago

Yep, it still works for me atm

LLuna-a commented 1 year ago

Yep, it still works for me atm

I did a clean install and it works really well thanks again @jjaychen1e

rhosta commented 1 year ago

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

Sorry, it's my mistake. I turn off other services when debug the code. Here is the updated version: LyricsX.app.zip

thanks a lot but it doesn't work on MacOS 10.14 or older.

jjaychen1e commented 1 year ago

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

Sorry, it's my mistake. I turn off other services when debug the code. Here is the updated version: LyricsX.app.zip

thanks a lot but it doesn't work on MacOS 10.14 or older.

This version supports macOS 10.13 or newer: LyricsX.app.zip

rhosta commented 1 year ago

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

Sorry, it's my mistake. I turn off other services when debug the code. Here is the updated version: LyricsX.app.zip

thanks a lot but it doesn't work on MacOS 10.14 or older.

This version supports macOS 10.13 or newer: LyricsX.app.zip

thanks, it works now!

yaojh123 commented 1 year ago

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

Sorry, it's my mistake. I turn off other services when debug the code. Here is the updated version: LyricsX.app.zip

seems still no QQ and Kugoo

keleqnma commented 1 year ago

same

Jechin commented 1 year ago

The feature "Auto Launch & Quit with music player" seems not to work?

BlackHandLYH commented 1 year ago

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

Sorry, it's my mistake. I turn off other services when debug the code. Here is the updated version: LyricsX.app.zip

thanks a lot but it doesn't work on MacOS 10.14 or older.

This version supports macOS 10.13 or newer: LyricsX.app.zip

OMG this one works like a charm! Thank you so much! 🥹

Hitoria commented 1 year ago

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Could you please upload a Universal app version? This only works on Apple Silicon.

Here is the universal version:

LyricsX.app.zip

It really helps a lot. This installation package is working very well. Thanks for your contribution.

EXistenz-78 commented 1 year ago

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

Sorry, it's my mistake. I turn off other services when debug the code. Here is the updated version: LyricsX.app.zip

thanks a lot but it doesn't work on MacOS 10.14 or older.

This version supports macOS 10.13 or newer: LyricsX.app.zip

Thank you so much!!! the app itself is great, but it was useless until you corrected this bug. I was waiting from months for this.

ervindobri commented 1 year ago

It doesn't work for me on Apple Silicon M1 PRO macbook.

“LyricsX” can’t be opened because Apple cannot check it for malicious software. This software needs to be updated. Contact the developer for more information.

Ein-Tim commented 1 year ago

@ervindobri Take a look at https://support.apple.com/en-gb/guide/mac-help/mchleab3a043/mac

timeblue8 commented 1 year ago

The same issue for me. Ventura 13.1

CharlesHim commented 1 year ago

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Could you please upload a Universal app version? This only works on Apple Silicon.

Here is the universal version:

LyricsX.app.zip

First, thanks a lot for your fixed version! It works!

However I noticed that your fixed version doesn't seem to support the feature "Auto Launch & Quit with music player". (Ventura 13.2.1, Mac mini with M2 chip)

After my attempts, I found the probable reason:

Allow Background

After I uninstall the original version and install the fixed version, the app should have been here when turn on the feature, which is probably used to support the feature (but the fixed app didn't appear here). So I think this may be the reason why the feature didn't work.

assdssao commented 1 year ago

@ervindobri Take a look at https://support.apple.com/en-gb/guide/mac-help/mchleab3a043/mac

非常感谢!!这非常有效的解决了我所有问题

myleo1 commented 1 year ago

ervices when debug the code. Here is the updated version: LyricsX.app.zip

thanks a lot but it doesn't work on MacOS 10.14 or older.

This version supports macOS 10.13 or newer: LyricsX.app.zip

It works fine on Monterey 12.5 M1 chip, Thanks a lot! 👍

HelloApeBoy commented 1 year ago

thx a lot.

StrangerFory commented 1 year ago

非常感谢,您的重构版本在13.3版本中也是工作的很好,向您学习。

Mrered commented 1 year ago

“自动启动和退出音乐播放器”功能似乎不起作用?

我也有此问题