dddooozzz9 / recastnavigation

Automatically exported from code.google.com/p/recastnavigation
zlib License
1 stars 0 forks source link

Possibly incorrect out of bounds index check in DetourCrowd.cpp #221

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Just noticed this in code, didn't try to create a repro case.

What is the expected output? What do you see instead?
In DetourCrowd.cpp, there are some instances of the following lines of code: 
if (idx < 0 || idx > m_maxAgents)
    return false;
e.g. requestMoveTargetReplan(), requestMoveTarget(), requestMoveVelocity(), 
resetMoveTarget()

Should the > condition be >= instead?

What version of the product are you using? On what operating system?
Exists in the latest version.

Please provide any additional information below.
-

Original issue reported on code.google.com by loonych...@gmail.com on 2 Nov 2012 at 11:16

GoogleCodeExporter commented 8 years ago
Fixed on github repo:
https://github.com/memononen/recastnavigation

Original comment by memono...@gmail.com on 19 Sep 2013 at 6:18