search

dddshelf / ddd-in-php-book-issues

Leave your comments, improvements or book mistakes as an issue! Thanks ❤️
https://leanpub.com/ddd-in-php
28 stars 2 forks source link

PostWasCreated event is missing implementation #55

Closed serroba closed 8 years ago

serroba commented 8 years ago

In 2.4.1 you create new instances of PostWasCreated() but although there is implementation for PostWasCreated() projector there is not the equivalent implementation of the Domain Event. I think it could add some clarity, in particular when using the same name for both (under different namespace), but they represent different things.

keyvanakbary commented 8 years ago

Wow, you were totally right. Very confusing. Renamed the projection implementations with the Projection suffix, so it becomes less confusing with plain Domain Events.

Thanks, I've included you in the acknowledgements! :)

serroba commented 8 years ago

Thanks!!! Was not expecting that ;)