search

dddshelf / ddd-in-php-book-issues

Leave your comments, improvements or book mistakes as an issue! Thanks ❤️
https://leanpub.com/ddd-in-php
28 stars 2 forks source link

UpdateOrderAmountService execute method not using orderId variable #76

Closed dfvalero closed 7 years ago

dfvalero commented 7 years ago

Hey! Congrats for the book!

There is a small mistake in the Anemic Domain Models vs. Rich Domain Models chapter.

There is a class called UpdateOrderAmountService trying to update the amount of an order, but instead of using the orderId you are forcing to find the order with the id = 1.

Thanks for all the knowledge!

keyvanakbary commented 7 years ago

Nice! Fixed it in master, should be already in Leanpub 👍 👏

I have included you in the Acknowledgments as "David Fernández", I hope I got it right from Google 😂

Thanks a lot!