dddshelf / ddd-in-php-book-issues

Leave your comments, improvements or book mistakes as an issue! Thanks ❤️
https://leanpub.com/ddd-in-php
28 stars 2 forks source link

Declaration must be compatible with Service #78

Closed IvixLabs closed 7 years ago

IvixLabs commented 7 years ago

Page 103 contains class SignInUserService implements Service { .... public function execute(SignInUserRequest $request) { .... later interface Service { public function execute($request); }

but php does not allows overrides function declaration except __construct.

Seem need avoid common service interface or modify all construction.

keyvanakbary commented 7 years ago

Hey, thanks for the issue. I'm not able to find the issue in the book, do you have the latest version of it?