ddeboer / imap

Object-oriented, fully tested PHP IMAP library
MIT License
889 stars 253 forks source link

Message headers: skip records with unsupported characters #546

Closed ivanghisleni closed 2 years ago

ivanghisleni commented 2 years ago

Fixes: https://github.com/ddeboer/imap/issues/545

Slamdunk commented 2 years ago

Hi, can you also add tests please?

ivanghisleni commented 2 years ago

@Slamdunk I'm generating test πŸ˜…

Slamdunk commented 2 years ago

Nice. You can also run the build locally, so the development feedback loop gets much faster, see https://github.com/ddeboer/imap#contributing-run-the-build-locally

codecov[bot] commented 2 years ago

Codecov Report

Merging #546 (7b43a68) into master (c2e4d72) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #546   +/-   ##
=========================================
  Coverage     95.57%   95.58%           
- Complexity      356      357    +1     
=========================================
  Files            45       45           
  Lines           837      838    +1     
=========================================
+ Hits            800      801    +1     
  Misses           37       37           
Impacted Files Coverage Ξ”
src/Message/Headers.php 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ivanghisleni commented 2 years ago

@Slamdunk I didn't change anything in AbstractPart.php where pipeline fails.... πŸ˜